Probably better overflow logic. Going to have Sean test this.

paulstraw · Dec 13, 2013 · 9a5556e · 9a5556e
1 parent ab302b4
commit 9a5556e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/fancySelect.coffee b/fancySelect.coffee
@@ -68,7 +68,7 @@ $.fn.fancySelect = (opts) ->
             offParent = parent.offsetParent()
 
             # TODO 20 is very static
-            if (parent.offset().top + parent.outerHeight() + options.outerHeight() + 20) > $(window).height()
+            if (parent.offset().top + parent.outerHeight() + options.outerHeight() + 20) > $(window).height() + $(window).scrollTop()
               options.addClass 'overflowing'
             else
               options.removeClass 'overflowing'

diff --git a/fancySelect.js b/fancySelect.js
diff --git a/index.html b/index.html
@@ -145,6 +145,12 @@ <h1>FancySelect</h1>
 					<option>Lorem Ipsum</option>
 					<option>Dolor Sit</option>
 					<option>Vehicula Ornare</option>
+					<option>Foo</option>
+					<option>Bar</option>
+					<option>Baz</option>
+					<option>Qux</option>
+					<option>Zoobie</option>
+					<option>Frang</option>
 				</select>
 
 				<p>FancySelect is easy to use. Just target any <code>select</code> element on the page, and call <code>.fancySelect()</code> on it. If the select has an option with no value, it'll be used as a sort of placeholder text.</p>