This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to a more verbose linting and make config.
Big-ish changes:
cmd
package intointernal/cmd
main.go
tocmd/go-newrelic
(result is binary now compiled intobin/<os>/go-newrelic
Most other changes are linting related. Lots of error checking on
w.Write()
(Should refactor these tests at a future date)The
api
package has not been moved, so this should be backwards compatible with external users or the library, unless they are wrappingcmd
which would seem like an odd thing to do.Due to that, we might want to consider this a for a
5.0.0
release, and if so I'd argue for some more refactoring first (breaking outapi
into domain specific packages, moving underpkg
, a bigger conversation to have)Alternatively, we can rollback the move of
cmd
package and change the Makefile to deal with it.Makefile enhancements: