Skip to content

Commit

Permalink
deploying version 2.3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
paulyoder committed Jan 19, 2015
1 parent 9c2faf8 commit 23bfa9f
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### 2.3.0

* Bug Fixes
* reverted the commit in v2.2.0 that no longer required inputs to have the form-control class. This broke select boxes.

### 2.2.0

* Enhancements
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-bootstrap-show-errors",
"version": "2.2.0",
"version": "2.3.0",
"authors": [
"Paul Yoder <paulyoder@gmail.com>"
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-bootstrap-show-errors",
"version": "2.2.0",
"version": "2.3.0",
"description": "An Angular Directive to intelligently show form validation errors",
"author": "Paul Yoder <paulyoder@gmail.com>",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion src/showErrors.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit 23bfa9f

@Divya-Bhardwaj
Copy link

@Divya-Bhardwaj Divya-Bhardwaj commented on 23bfa9f Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sir

I go through your blog 'angular-bootstrap-show-errors' on Git.

I faced an issue in my application and the scenario is :
"Fields on form : 1 dropdown, 2 Input boxes
values in dropdown (A & B)
If we select A, input boxes are enabled.
If we select B, input boxes are disabled.

What I noticed :
Case 1: If I touched input boxes and submit the form, fields get highlighted red. Then change dropdown value to B (notice: red color of boundary get removed)
Case 2: If input boxes are untouched and submit the form, fields again get highlighted red. Then change dropdown value to B (notice: red color of boundary is still exist which needs to be removed).

What I observe, in case1 { .form-control[disabled] } class get applied whereas in case2 { .has-error } not get changed.

Can you please suggest any solution for this???

Please sign in to comment.