New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into stable #259
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support mapped value subscription restrictions - Restrict permitted guest value to standard and business
FIX: compound selectors may no longer be extended
Add guest support
Tag group restriction fix
FIX: (File|Dir).exists? is deprecated
…te_override IMPROVE: Move pending wizard check to page change event
…_on_wizard_delete FIX: ensure related create topic wizard setting is removed when wizard is deleted
FIX: direct after start time default for new wizard
…_on_wizard_delete FIX: Remove category custom field on wizard delete (Take Two)
Update subscription client class to support gem version of Subscription Client
angusmcleod
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we bumped the version?
This version of the PR would be 2.4.16 same as the main version, or should it be 2.4.17? Is that the reason the frontend test is failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved a conflict between main and stable. All test have passed in discourse stable branch @angusmcleod