Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix #289

Merged
merged 3 commits into from Mar 11, 2024
Merged

Small fix #289

merged 3 commits into from Mar 11, 2024

Conversation

jumagura
Copy link
Member

@jumagura jumagura commented Mar 7, 2024

I found that Trust Level 3 users are automatically part of group 13. Correct me if I'm wrong, please.

group = Group.find(Group::AUTO_GROUPS[:trust_level_3])
puts group.id
# Outputs: 13

which is why this test failed. I updated the test to use permitted_admin.json, which restricts access to the admin group.

Feedback is highly appreciated

@merefield merefield self-requested a review March 11, 2024 16:40
@jumagura jumagura removed the request for review from angusmcleod March 11, 2024 16:40
merefield
merefield approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@merefield merefield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @jumagura !

@merefield merefield merged commit bf8bbfb into main Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merefield merefield merefield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jumagura @merefield