Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated remote modal #18

Merged
merged 3 commits into from Sep 29, 2023
Merged

Updated remote modal #18

merged 3 commits into from Sep 29, 2023

Conversation

cabidop
Copy link
Contributor

@cabidop cabidop commented Sep 26, 2023

This is a revamp of the remote modal to include the following changes:

  • Removal of the deprecation warnings according to this guide (similar approach as with the "import page" modal in Fixed deprecation warnings and bugs on page operations #11)
  • Simplification of the component flow by using the buffered-content Discourse mixin instead of a custom implementation.
  • Addition of a reset button to remove the remote configuration if it exists (only EmberJS code as the Rails endpoint was already present).

@angusmcleod angusmcleod self-requested a review September 27, 2023 00:42
Copy link
Member

@angusmcleod angusmcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabidop Looks good! The only (minor) thing I'm noticing is that the addition of the reset button means that the modal footer is not quite wide enough to accommodate the loading spinner without expanding slightly when it appears. The width of the modal shouldn't change.

https://www.loom.com/share/7f437bdd20214cb29d1ba280b10015f0

@cabidop
Copy link
Contributor Author

cabidop commented Sep 27, 2023

Fixed, @angusmcleod, after the modal upgrade the CSS classes were not being properly picked and there was no min-width being set for the container.

@angusmcleod
Copy link
Member

@cabidop I'm being pedantic I know, but the cancel button is moving now :)

https://www.loom.com/share/16274d86c37d43e29f3c598e3a6b67fb

Perhaps we can align that on the right of the footer? Just visually it doesn't look great when other elements are moved by a loading spinner. Sorry to be so picky. You seem on top of things though, so I think you can handle being held to a high standard.

@cabidop
Copy link
Contributor Author

cabidop commented Sep 28, 2023

No worries, @angusmcleod! It was actually another "broken" style from the modal upgrade so the cancel button should be properly aligned now.

@angusmcleod angusmcleod self-requested a review September 29, 2023 00:19
Copy link
Member

@angusmcleod angusmcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabidop Looks good 👍

@angusmcleod angusmcleod merged commit 2ac276c into paviliondev:main Sep 29, 2023
3 checks passed
@cabidop cabidop deleted the remote-fix branch September 29, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants