FIX: location search debounce

[renato]

On the location-selector, self.get('settings.location_geocoding_debounce') was always undefined when calling geoLocationSearch, I'm not too familiar with Ember but adding @computed to settings fixed it.

Even with the proper value the debounce function wasn't working as expected, changing the way the request and callback args were passed to the locationSearch function also fixed it – I believe passing a new function every time makes it start a new debounce context for each call and not debounce at all.

[merefield]

Thanks @renato ... let me check something with @angusmcleod here because I think some of this code is legacy and should be removed.

@angusmcleod this line may be out of date now there have been architectural changes in CW, can you please confirm?:

discourse-locations/assets/javascripts/discourse/components/location-selector.js.es6

Line 14 in 82c446a

return rootElement === '#custom-wizard-main' ? Wizard.SiteSettings : this.siteSettings;

should this simply be removed and we should always reference core siteSettings now?

[angusmcleod]

@renato Thanks!