Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves playback compatibility by relying on a third-party library and, most importantly, converting the output to MP3. The library uses
AudioContext
API, so the output can be processed to MP3 using a web worker.The changes are pretty straightforward.
It fixes two minor issues as well:
@tracked
on_audioData
)Added a few tests:
Note: The user needs to allow the
mp3
extension inauthorized_extensions
orauthorized extensions_staff
settings.