Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Improve playback support #6

Merged
merged 1 commit into from Apr 25, 2024

Conversation

Arkshine
Copy link
Contributor

This PR improves playback compatibility by relying on a third-party library and, most importantly, converting the output to MP3. The library uses AudioContext API, so the output can be processed to MP3 using a web worker.

The changes are pretty straightforward.
It fixes two minor issues as well:

  • The audio length would not change after the first recording (missing @tracked on _audioData)
  • Make sure to clean any recording if the modal is closed

Added a few tests:

image

Note: The user needs to allow the mp3 extension in authorized_extensions or authorized extensions_staff settings.

Copy link
Member

@angusmcleod angusmcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arkshine Great work!

@angusmcleod angusmcleod merged commit 377cbb8 into paviliondev:main Apr 25, 2024
@Arkshine
Copy link
Contributor Author

Thanks for giving me feedback; I appreciate it!

@Arkshine Arkshine deleted the feature/playback-improvement branch April 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants