Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct UnboundLocalError #45

Closed
wants to merge 378 commits into from
Closed

Correct UnboundLocalError #45

wants to merge 378 commits into from

Conversation

sethrh
Copy link
Contributor

@sethrh sethrh commented Mar 22, 2016

This corrects is a somewhat obscure error that occurs when a jsonrpc method has PEP3107 annotations, and is then called with incorrect parameters.

@pavlov99
add dispatcher to jsonrpc
b0c62df
@pavlov99
Merge branch 'feature/dispatcher' into develop
126b498
@pavlov99
add utils to jsonrpc
e79f091
@pavlov99
add jsonrpc 2.0 request
663326a
@pavlov99
update utils (python 2.7 compatibility)
c165546
@pavlov99
add test to check set/unset is_notification attribute (check id in data)
426717b
@pavlov99
Add tests for json rpc batch request
6f2587e
@pavlov99
simplify code, add verbosity to errors
bfe9d0b
@pavlov99
update tests for jsonrpc2.0 functionality
6d895b1
@pavlov99
move tests for json rpc errors to another file. They could be used in…
c8eeaa9 
… both standards
@pavlov99
move jsonrpc2.0 functionality to corresponding modules
5cf8ec6
@pavlov99
add .ropeproject to gitignore
69c55bc
@pavlov99
fix test name (error was with bulk update dict -> data)
b1864fb
@pavlov99
remove inherited fields redefinition
d7ed8bc
@pavlov99
remove batch response test in jsonrpc. It is tested in jsonrpc20
dbbf551
@pavlov99
init jsonrpc10 functionality
7cc073c
@pavlov99
add validation to jsonrpc1.0
9e4233b
@pavlov99
reorder init steps, set id before is_notification to satisfy both jso…
d51d675 
…nrpc1 and jsonrpc2 implementations
@pavlov99
add tests to jsonrpc1
eaf0944
@pavlov99
fix jsonrpc1 is_notification implementation
0329e07
@pavlov99
add (python) Exceptions classes
bb0acce
@pavlov99
check format of message during parse for jsonrpc2
6edd2f1
@pavlov99
implement from_json functionality for jsonrpc1 request
3f12bb8
@pavlov99
remove extra blank lines
4b4a837
@pavlov99
update readme todo
d368951
@pavlov99
update jsonrpc response functionality
a0a9329
@pavlov99
move manager functionality to manager file
1a4ad1f
@pavlov99
reject null id for JSONRPC10
8952cd0
@pavlov99
simplify condition
902d058
@pavlov99
add tests
065f3c3
pavlov99 and others added 17 commits January 31, 2016 13:12
@pavlov99
drop python 3.2 support, fix coverage report arguments
13e7c8d
@pavlov99
use master branch to display badge. Otherwise any pull request could …
b16adbd 
…make badge red, indicating broken build.
@pavlov99
fix minimal python3 version support in readme
556c4b6
@pavlov99
Merge branch 'master' into develop
93c813a
@pavlov99
add contributors to README
b32084f
@pavlov99
use NotImplementedError instead of NotImplemented in utils, so fix th…
65cb04c 
…at in coverage report as well.
@pavlov99
remove not supported pypin badges.
3763a2f
@pavlov99
fix typo
2b7d5af
@arnuschky
Merge remote-tracking branch 'upstream/develop' into bug-csrf-exempt
5db123a
@pavlov99
init python3.5 tests
a4584e3
@pavlov99
merge with pull-request master branch
922432e
@pavlov99
remove extra code
2ec92cc
@pavlov99
Merge branch 'arnuschky-bug-csrf-exempt' into develop
364b21f
@pavlov99
update contributors list
c9bf093
@pavlov99
update version
8db3f5d
@pavlov99
Merge branch 'release/1.10.3'
f35f16b
@sethrh
Correct UnboundLocalError
9914ab5 
Occurs when jsonrpc method has PEP3107 annotations, and is called with
incorrect parameters.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 99.048% when pulling 9914ab5 on QuantumSpatialInc:master into f35f16b on pavlov99:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 99.048% when pulling 60e26e3 on QuantumSpatialInc:master into f35f16b on pavlov99:master.

@pavlov99
Copy link
Owner

Good job! Unfortunately, tests have failed, so we need to figure it out first. Issue is with import, should not be hard.

@pavlov99 pavlov99 self-assigned this Mar 23, 2016
@pavlov99 pavlov99 closed this Oct 28, 2017
@pavlov99 pavlov99 mentioned this pull request Oct 29, 2017
Open
8 tasks
@S1983tt
Copy link

S1983tt commented Oct 20, 2022

This corrects is a somewhat obscure error that occurs when a jsonrpc method has PEP3107 annotations, and is then called with incorrect parameters.

#45

@pavlov99
Copy link
Owner

Could you please rebase? Github says that the merge contains 378 commits.

@sethrh
Copy link
Contributor Author

sethrh commented Nov 23, 2022

I'm sorry, I have no memory of this PR. Has this been hanging since 2016 or did something else happen recently to reanimate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pavlov99 pavlov99

Labels
in progress ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet