Log exception in RPC function regardless of exception type #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful as a server-side developer to see the stack trace regardless if the error is a TypeError or not.
|
@durden, it makes sense. Do you think it would be better to add such message after |
This gives the exception message more context with the data that will be returned in response.
|
@pavlov99 Good point, updated the PR with your suggestion. Thanks for feedback! |
|
Thanks for the merge! Do you have a set release schedule? Curious when this might be available as official on pypi. No rush, just curious. |
pavlov99
added a commit
that referenced
this pull request
Oct 28, 2017
Log exception in RPC function regardless of exception type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful as a server-side developer to see the stack trace regardless if the error is a TypeError or not.