-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying frequency lists in ZXCVBNValidator options #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one thing to change 🙂
Could you also add usage example documentation to the README?
Perfect! Thanks 🙂 I'll try to release a new version ASAP. |
Thanks so much! |
In my case the only thing that we do client-side is show the password strength bar. To make sure we get the same calculation in the bar as in the django's password validation we created a view that does the same call to zxcvbn as the password validation. Then we use that score as feedback in the password strength bar. This can be as simple as:
This has the advantage that the user does not need to download the (rather large) zxcvbn client-side library. |
Hmmm, interesting. I guess this should have been done this way from the beginning. I'll open a new issue. |
This PR allows specifying frequency_lists in the ZXCVBNValidator options by adding a dict in the following form: