Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invalid Token #8

Merged
merged 6 commits into from
Oct 6, 2017
Merged

Fix Invalid Token #8

merged 6 commits into from
Oct 6, 2017

Conversation

bartonp
Copy link
Contributor

@bartonp bartonp commented Sep 30, 2017

  • Fixes issue OAuth token refreshing doesn't work #5
  • Adds being able to not specify the client_secret if you have a valid token. When the functions that use a client_secret are used they will raise 'UnableToGetToken' exception when the client_secret is none.

@coveralls
Copy link

coveralls commented Sep 30, 2017

Coverage Status

Coverage decreased (-1.3%) to 93.878% when pulling c71510d on bartonp:bug-refresh_token into 6735487 on pawelad:master.

@pawelad
Copy link
Owner

pawelad commented Oct 2, 2017

First of all, thanks a lot for taking the time to submit this! Sorry for taking so long to response, I'll try to find some free time today to review it and possibly merge it.

@pawelad pawelad self-assigned this Oct 6, 2017
@pawelad pawelad self-requested a review October 6, 2017 01:31
@pawelad
Copy link
Owner

pawelad commented Oct 6, 2017

Could you please Allowing changes to a pull request branch created from a fork? I like the changes but added a couple other things as well.

@pawelad
Copy link
Owner

pawelad commented Oct 6, 2017

Could you please Allowing changes to a pull request branch created from a fork? I like the changes but added a couple other things as well.

My bad, this was already allowed.

@coveralls
Copy link

coveralls commented Oct 6, 2017

Coverage Status

Coverage increased (+0.1%) to 95.288% when pulling c7c7d86 on bartonp:bug-refresh_token into 6735487 on pawelad:master.

@pawelad
Copy link
Owner

pawelad commented Oct 6, 2017

I added the ability to save client_secret in the JSON token file to so it's possible to refresh multiple times, between shell/computer reboots.

Thanks again for the PR, will do a release in a second.

@pawelad pawelad merged commit fd9d2ad into pawelad:master Oct 6, 2017
Copy link
Owner

@pawelad pawelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants