Properly fix duplicated admin sections #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "fix" only worked because it gave an invalid class in info.xml and prevented a double registration of the admin section with this. See pawelrojek#63 for details. This reverts commit b74bf38.
This removes the registerAdmin() call in the App initialization. It is not necessary as we already declared the admin class in the appinfo/info.xml. Leaving it there causes the settings to appear twice. This should finally fix pawelrojek#4 without causing the issue described in pawelrojek#63. Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
All the other sections in my instance have an id here. Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a proper fix for tssue #4 and reverts the former fix that caused #63.