Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel past due subscriptions immediately instead of next period #848

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

excid3
Copy link
Collaborator

@excid3 excid3 commented Sep 25, 2023

When a subscription is past_due, cancelling it should immediately cancel the subscription instead of canceling at period end. Without this, the customer would get an extra period of access on accident.

Copy link
Collaborator

@cjilbert504 cjilbert504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one!

@excid3 excid3 merged commit 99d13c3 into master Oct 17, 2023
33 checks passed
@excid3 excid3 deleted the cancel-past-due-immediately branch October 17, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants