Avoid duplicating your options when you have priority countries.

Otherwise you can end up with multiple selected options which causes invalid html code
payango · Aug 4, 2010 · 3e7ead2 · 3e7ead2
1 parent 99b494e
commit 3e7ead2
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/localized_country_select.rb b/lib/localized_country_select.rb
@@ -67,8 +67,10 @@ def localized_country_options_for_select(selected = nil, priority_countries = ni
         if priority_countries
           country_options += options_for_select(LocalizedCountrySelect::priority_countries_array(priority_countries), selected)
           country_options += "<option value=\"\" disabled=\"disabled\">-------------</option>\n"
+          return country_options + options_for_select(LocalizedCountrySelect::localized_countries_array - LocalizedCountrySelect::priority_countries_array(priority_countries), selected)
+        else
+          return country_options + options_for_select(LocalizedCountrySelect::localized_countries_array, selected)
         end
-        return country_options + options_for_select(LocalizedCountrySelect::localized_countries_array, selected)
       end
 
     end