-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Failure "CDI deployment failure:null" for Jersey GuiceContainer application #2112
Comments
Created internal issue |
One observation - while I agree that the use of EmptyList may be what gives rise to the Exception, and changing that was how I "worked-round" the problem - during my debug of this I got the impression there was a problem upstream of this. If I understand this right (and I'm no expert in thist area, so happy to be corrected) the Jersey GuiceContainer is providing CDI in our application and not relying on WELD in the Payara container. So setting "bean-discovery-mode=none" would be the right setting for this and org.glassfish.weld.DeploymentImpl should not actually get called. This is the case in 411_162 but not in 412_173 where the "none" setting appears to get ignored. From Debug In org.glassfish.weld.WeldDeployer.event (WeldDeployer.java)
For 411_162
Then in
No call is made into org.glassfish.weld.DeploymentImpl and deploy succeeds and app operates. For 412_173
So (to me) it looks like it's ignoring this "none" and running the Weld DeploymentImpl (which aligns with observations in #1825). One further observation (while I'm here) When using "deploy" with command line as above (i.e.. using a "--name") which is our usual method of deployment then:
which looked a little weird - even though the beans.xml still seemed to get read |
* #2112 removed usage of Collections.emtpyList() to prevent exception if the returned list will be modified. Replaced lazy initialisation of list and replaced usage of calls of size() > 0 with !isEmpty. * #2112 removed several more usages of emptyList() constructed lists. At least one of them may modified. * Fixed copyright
I have built on latest commit on master (including 5cc4c6e...) Deploying the SSCCE (attached) gives
and (several exceptions below) as my comment above - with a setting of "none" in beans.xml I wasn't expecting Weld dependencies to come into this.
|
Assigned internal issue |
@dazed19 For now, as a workaround, you can use the following command to successfully deploy: |
… CDI extensions such as Soteria etc. won't fail Fixes payara#2112
* Disable CDI when WAR bean archive is set to BeanDiscoveryMode.NONE so CDI extensions such as Soteria etc. won't fail Fixes #2112 * fixed failing tests
This seems to fix #1825 . |
…ara#2192) * Disable CDI when WAR bean archive is set to BeanDiscoveryMode.NONE so CDI extensions such as Soteria etc. won't fail Fixes payara#2112 * fixed failing tests
…ara#2192) * Disable CDI when WAR bean archive is set to BeanDiscoveryMode.NONE so CDI extensions such as Soteria etc. won't fail Fixes payara#2112 * fixed failing tests
Hi Thanks - I have tested both of these successfully - the work-around "enable-implicit-cdi=false" and the fix in build. |
Description
Deploying a Jersey GuiceContainer application via the command line worked in Payara_411_162 but fails in Payara_412_173 with an exception.
Expected Outcome
Application should deploy (as per 411_162) and operate
Current Outcome
When deploying a Jersey GuiceContainer application via command line - console gives
Plus Exception in server.log
Steps to reproduce (Only for bug reports)
SSCCE attached which reproduces this.
Build SSCCE application
Start Domain
Samples
GuiceDeploySscce.zip
Context (Optional)
This is impacting our ability to upgrade Payara to latest versions - we are stuck on old version 411_162 - as we can't deploy our application
Other Input
Issue was first raised in Payara User Forum which includes output from debug of both 162 and 173 on this issue - including "work-around" for issue.
Environment
The text was updated successfully, but these errors were encountered: