Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-1727 Setting of -1 for time-to-keep-queries-in-minutes results… #1747

Merged
merged 6 commits into from
Jul 24, 2017
Merged

PAYARA-1727 Setting of -1 for time-to-keep-queries-in-minutes results… #1747

merged 6 commits into from
Jul 24, 2017

Conversation

Cousjava
Copy link
Contributor

@Cousjava Cousjava commented Jul 5, 2017

… in SQL trace being kept permanently

@Cousjava Cousjava added this to the Payara 173 milestone Jul 5, 2017
@Cousjava
Copy link
Contributor Author

Cousjava commented Jul 5, 2017

jenkins test please

smillidge
smillidge requested changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@smillidge smillidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the potential to blow up the heap in the server so will require a level of protect to stop the map size getting out of hand. Perhaps a configurable max size.

@payara-ci
Copy link
Contributor

One or more tests have failed

@smillidge
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

@Cousjava
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge smillidge merged commit 5c62917 into payara:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smillidge smillidge smillidge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 173
Development

Successfully merging this pull request may close these issues.
4 participants
@Cousjava @payara-ci @smillidge @fturizo