PAYARA-1954 Added get rest monitoring configuration command #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
|
Quick build and test passed! |
MattGill98
approved these changes
Aug 25, 2017
smillidge
approved these changes
Aug 28, 2017
Scoty
reviewed
Sep 1, 2017
| public void execute(AdminCommandContext context) { | ||
| Config config = targetUtil.getConfig(target); | ||
|
|
||
| RestMonitoringConfiguration restMonitoringConfiguration = config |
There was a problem hiding this comment.
Correct me if I am wrong, but it looks like NPE is possible here ? I guess this row should be below the null check for the config variable?
There was a problem hiding this comment.
Good spot! I agree this should be below the null check.
michaelranaldo
added a commit
to michaelranaldo/Payara
that referenced
this pull request
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.