PAYARA-3487 Race condition in ConnectionPool #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing an exception. A multiexception is printed, showing both the current stack trace and the trace of where the resource was previouslt closed.
|
Jenkins test please |
pdudits
suggested changes
May 2, 2019
| @@ -67,6 +69,20 @@ public boolean isBusy() { | |||
|
|
|||
| public void setBusy(boolean busy) { | |||
| this.busy = busy; | |||
| if (!busy) { | |||
| busyException = new TwiceBusyException(); | |||
There was a problem hiding this comment.
Can this be controlled by a system property? I believe there is significant overhead in collecting stacktrace at every connection close.
...ectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Outdated
Show resolved
Hide resolved
jbee
reviewed
May 2, 2019
...r/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/ResourceState.java
Show resolved
Hide resolved
|
Jenkins test please |
pdudits
approved these changes
May 10, 2019
jbee
approved these changes
May 14, 2019
Pandrex247
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connectionpool is closed it now logs an error rather than throwing an exception.
A multiexception is printed, showing both the current stack trace and the trace of where
the resource was previously closed.