Create Payara POM #4062
Create Payara POM #4062
Conversation
- version properties moved to aggregator - all dependencies ending up in modules directory moved to bom - where possible individual modules replaced with BOM
|
jenkins test please |
🎉 |
| <jcip-annotations.version>1.0-1</jcip-annotations.version> | ||
| <!-- Yubico client validation version property --> | ||
| <yubico-validation-client2.version>3.0.2.payara-p1</yubico-validation-client2.version> | ||
|
|
||
| <dockerfile-maven-plugin.version>1.4.10</dockerfile-maven-plugin.version> |
There was a problem hiding this comment.
What's the reasoning behind some properties being left in this POM?
E.g. this one, and the javaee.major_version property?
There was a problem hiding this comment.
I believe it's because they didn't affect any content in modules folder. Even though it's bit surprising for javaee.major_version, isn't it?
There was a problem hiding this comment.
I imagine you can get away with that one as nucleus is supposed to be pure application server, with appserver being the additional stuff to turn it into a Java / Jarkarta EE application server.
| <groupId>org.glassfish.main</groupId> | ||
| <artifactId>glassfish-main-aggregator</artifactId> | ||
| <groupId>fish.payara</groupId> | ||
| <artifactId>payara-main-aggregator</artifactId> |
There was a problem hiding this comment.
Do we want to take this chance to drop the main part?
That's a GlassFish holdover I believe.
There was a problem hiding this comment.
Yes, good idea. But now I'm also thinking about groupId fish.payara.server again, or actually fish.payara.main
There was a problem hiding this comment.
I prefer server over main.
main implies that there's something that isn't.
Alternatively you can simply go with fish.payara as the groupId for the top-level pom, then fish.payara.nucleus and fish.payara.appserver in the respective folders. That's just me spit-balling though
There was a problem hiding this comment.
Maybe its a good chance to move away from nucleus? Its a word that only makes sense if you know what is meant in the context in which case any word would work. Instead we could use words that communicate something even to people who do not know the context.
|
This is now conflicting with jakarta dependencies being brought in, and it is also not a good thing to add in last sprint of a release. Will redo that for 194 next month |
The BOM contains all third-party dependencies of Payara codebase, that get copied into modules directory, as well as public artifacts that are published.
This should prevent ecosystem projects as well as users not import incompatible third-party or transitive dependencies.
This is what changed: