PAYARA-4219 Problem when trying to override System Properties of an instance

[AlanRoth]

Description

This is a bug fix

Overriding system properties in {Instance Name}-config -> System Properties -> Instance Values failed stating "An error has occured"

Testing

On a new Instance running/stopped e.g Elegant-Archerfish

• Go to Instances -> Elegant-Archerfish -> Properties -> System Properties changing an Override value should change Current Value
• Go to Configurations -> Elegant-Archerfish-config -> System Properties -> Instance Values changing the Override Value should save successfully.

Note: Default Value will remain the same unless changed in the configuration

Check the override value has been applied by going back to Instances -> Elegant-Archerfish -> Properties -> System Properties you should see the new override value. The instance may need to be restarted.

Testing Performed

Build tests
Testing against acceptance criteria

Testing Environment

Manjaro 18.0.4
Maven 3.6.1
Zulu JDK 1.8.0_222

[AlanRoth]

jenkins test please

[cubastanley]

I tested this locally and it does make a difference but an error is still given - just has a specified error message

[AlanRoth]

I tested this locally and it does make a difference but an error is still given - just has a specified error message

What does the error say? And is it in Instance values?

[cubastanley]

I tested this locally and it does make a difference but an error is still given - just has a specified error message

What does the error say?

An error occurred during replication Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed - don't know if this is expected or not

[AlanRoth]

I tested this locally and it does make a difference but an error is still given - just has a specified error message

What does the error say?

An error occurred during replication Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed - don't know if this is expected or not

Not expected at all usually, which system property did you override? As that might bork things up, http listener port is a safe one to try

[Pandrex247]

Danger Will Robinson!
I'm very wary of this change - I need to give this a thorough bashing to ensure it doesn't blow something up.
Lots of things use this method, sending all kinds of gubbins through it e.g. Rest Management Interface sending Json

[AlanRoth]

I see, I think it can be safe to revert, the jsf specifies the content type when it calls the rest request

[Pandrex247]

The change fixes the problem described, but I need to get out my baseball bat and give this a thwacking to see if any bugs fall out.

[Pandrex247]

I didn't get any PKIX errors @cubastanley, that's an odd error to get - normally something to do with, well, certificates.

[AlanRoth]

I didn't get any PKIX errors @cubastanley, that's an odd error to get - normally something to do with, well, certificates.

I reproduced it once using some unorthodox values (not 100% of the time)

[cubastanley]

Assuming I caused my issue, does stop the problem stated in ticket so - aproooved

[AlanRoth]

jenkins test please