Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4219 Problem when trying to override System Properties of an instance #4321

Merged
merged 3 commits into from Nov 20, 2019

Conversation

@AlanRoth
Copy link
Contributor

AlanRoth commented Nov 13, 2019

Description

This is a bug fix

Overriding system properties in {Instance Name}-config -> System Properties -> Instance Values failed stating "An error has occured"

Testing

On a new Instance running/stopped e.g Elegant-Archerfish

  • Go to Instances -> Elegant-Archerfish -> Properties -> System Properties changing an Override value should change Current Value
  • Go to Configurations -> Elegant-Archerfish-config -> System Properties -> Instance Values changing the Override Value should save successfully.

Note: Default Value will remain the same unless changed in the configuration

Check the override value has been applied by going back to Instances -> Elegant-Archerfish -> Properties -> System Properties you should see the new override value. The instance may need to be restarted.

Testing Performed

Build tests
Testing against acceptance criteria

Testing Environment

Manjaro 18.0.4
Maven 3.6.1
Zulu JDK 1.8.0_222

@AlanRoth AlanRoth requested review from Pandrex247 and cubastanley Nov 13, 2019
@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

AlanRoth commented Nov 13, 2019

jenkins test please

@cubastanley

This comment has been minimized.

Copy link
Contributor

cubastanley commented Nov 13, 2019

I tested this locally and it does make a difference but an error is still given - just has a specified error message

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

AlanRoth commented Nov 13, 2019

I tested this locally and it does make a difference but an error is still given - just has a specified error message

What does the error say? And is it in Instance values?

@cubastanley

This comment has been minimized.

Copy link
Contributor

cubastanley commented Nov 13, 2019

I tested this locally and it does make a difference but an error is still given - just has a specified error message

What does the error say?

An error occurred during replication Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed - don't know if this is expected or not

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

AlanRoth commented Nov 13, 2019

I tested this locally and it does make a difference but an error is still given - just has a specified error message

What does the error say?

An error occurred during replication Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed Failure: Command delete-system-property failed on server instance Dark-Minnow: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed - don't know if this is expected or not

Not expected at all usually, which system property did you override? As that might bork things up, http listener port is a safe one to try

@Pandrex247 Pandrex247 added this to the 5.194 milestone Nov 13, 2019
@@ -885,7 +885,7 @@ public static RestResponse post(String address, Object payload, String contentTy
}
Response cr = target.request(RESPONSE_TYPE).header("Content-Type", contentType)
.cookie(new Cookie(REST_TOKEN_COOKIE, getRestToken()))
// .header("Content-type", MediaType.APPLICATION_FORM_URLENCODED)
.header("Content-type", MediaType.APPLICATION_FORM_URLENCODED)

This comment has been minimized.

Copy link
@Pandrex247

Pandrex247 Nov 13, 2019

Member

Danger Will Robinson!
I'm very wary of this change - I need to give this a thorough bashing to ensure it doesn't blow something up.
Lots of things use this method, sending all kinds of gubbins through it e.g. Rest Management Interface sending Json

This comment has been minimized.

Copy link
@AlanRoth

AlanRoth Nov 13, 2019

Author Contributor

I see, I think it can be safe to revert, the jsf specifies the content type when it calls the rest request

Copy link
Member

Pandrex247 left a comment

The change fixes the problem described, but I need to get out my baseball bat and give this a thwacking to see if any bugs fall out.

@Pandrex247

This comment has been minimized.

Copy link
Member

Pandrex247 commented Nov 13, 2019

I didn't get any PKIX errors @cubastanley, that's an odd error to get - normally something to do with, well, certificates.

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

AlanRoth commented Nov 13, 2019

I didn't get any PKIX errors @cubastanley, that's an odd error to get - normally something to do with, well, certificates.

I reproduced it once using some unorthodox values (not 100% of the time)

Copy link
Contributor

cubastanley left a comment

Assuming I caused my issue, does stop the problem stated in ticket so - aproooved

Unnecessary change
@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

AlanRoth commented Nov 19, 2019

jenkins test please

@AlanRoth AlanRoth merged commit 11830c3 into payara:master Nov 20, 2019
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.