-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUSTCOM-81 Display port number on start-domain with --debug=true option #4387
Conversation
Created internal issue CUSTCOM-81 |
Jenkins test please |
@@ -1,7 +1,7 @@ | |||
/* | |||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. | |||
* | |||
* Copyright (c) 2008-2015 Oracle and/or its affiliates. All rights reserved. | |||
* Copyright (c) 2008-2019 Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a question: why you updated this copyright year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the one already in place, hidden at
Payara/nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncher.java
Line 40 in 285289a
// Portions Copyright [2016-2019] [Payara Foundation and/or its affiliates] |
Have not revoked OCA, so it's still kind of true 😉 I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmatej I'm going to check my pending open PRs.
Just for reference - one sonar finding fixed 😉 |
This is a bug fix. (#4386)
Current
GFLauncher
recognizes only old-style JDWP option (-Xrunjdwp
), but by default from template new one (-agentlib:jdwp
) is used. With the effect of port not parsed from option (defaulted to -1),Payara/nucleus/admin/server-mgmt/src/main/java/com/sun/enterprise/admin/servermgmt/cli/StartServerHelper.java
Line 268 in c290512
Testing Performed
After full build following performed:
which resulted in
Testing Environment