CUSTCOM-81 Display port number on start-domain with --debug=true option

[pzygielo]

This is a bug fix. (#4386)

Current GFLauncher recognizes only old-style JDWP option (-Xrunjdwp), but by default from template new one (-agentlib:jdwp) is used. With the effect of port not parsed from option (defaulted to -1),

Payara/nucleus/admin/server-mgmt/src/main/java/com/sun/enterprise/admin/servermgmt/cli/StartServerHelper.java

Line 268 in c290512

if (debugPort >= 0) {

is not fulfilled, and expected message is not logged.

Testing Performed

After full build following performed:

unzip  appserver/distributions/payara/target/payara.zip
./payara5/glassfish/bin/asadmin start-domain --debug=true

which resulted in

Waiting for domain1 to start ............
Successfully started the domain : domain1
domain  Location: /tmp/payara5/glassfish/domains/domain1
Log File: /tmp/payara5/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Debugging is enabled.  The debugging port is: 9009
Command start-domain executed successfully.

Testing Environment

• Linux
• OpenJDK Runtime Environment (build 1.8.0_232-b09)
• Maven 3.6.3

[dmatej]

Created internal issue CUSTCOM-81

[Cousjava]

Jenkins test please

[dmatej]

Only a question: why you updated this copyright year?

[pzygielo]

I missed the one already in place, hidden at

Payara/nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncher.java

Line 40 in 285289a

// Portions Copyright [2016-2019] [Payara Foundation and/or its affiliates]

Have not revoked OCA, so it's still kind of true 😉 I think.

[pzygielo]

@dmatej I'm going to check my pending open PRs.

[pzygielo]

Just for reference - one sonar finding fixed 😉