Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-81 Display port number on start-domain with --debug=true option #4387

Merged
merged 3 commits into from Jan 8, 2020

Conversation

@pzygielo
Copy link
Contributor

pzygielo commented Dec 14, 2019

This is a bug fix. (#4386)

Current GFLauncher recognizes only old-style JDWP option (-Xrunjdwp), but by default from template new one (-agentlib:jdwp) is used. With the effect of port not parsed from option (defaulted to -1),

is not fulfilled, and expected message is not logged.

Testing Performed

After full build following performed:

unzip  appserver/distributions/payara/target/payara.zip
./payara5/glassfish/bin/asadmin start-domain --debug=true

which resulted in

Waiting for domain1 to start ............
Successfully started the domain : domain1
domain  Location: /tmp/payara5/glassfish/domains/domain1
Log File: /tmp/payara5/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Debugging is enabled.  The debugging port is: 9009
Command start-domain executed successfully.

Testing Environment

  • Linux
  • OpenJDK Runtime Environment (build 1.8.0_232-b09)
  • Maven 3.6.3
pzygielo added 3 commits Dec 14, 2019
Fixes #4386
@pzygielo pzygielo marked this pull request as ready for review Dec 15, 2019
@dmatej dmatej requested review from Cousjava and jGauravGupta Dec 15, 2019
@dmatej

This comment has been minimized.

Copy link
Contributor

dmatej commented Dec 15, 2019

Created internal issue CUSTCOM-81

@Cousjava Cousjava changed the title Display port number on start-domain with --debug=true option CUSTCOM-81 Display port number on start-domain with --debug=true option Dec 17, 2019
@Cousjava

This comment has been minimized.

Copy link
Member

Cousjava commented Dec 17, 2019

Jenkins test please

@dmatej
dmatej approved these changes Jan 8, 2020
@dmatej dmatej merged commit 1079fa9 into payara:master Jan 8, 2020
5 of 9 checks passed
5 of 9 checks passed
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) Test in progress
security/snyk - appserver/persistence/pom.xml (payara-ci) Test in progress
security/snyk - copyright/pom.xml (payara-ci) Test in progress
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) Test in progress
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
@@ -1,7 +1,7 @@
/*
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
*
* Copyright (c) 2008-2015 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2008-2019 Oracle and/or its affiliates. All rights reserved.

This comment has been minimized.

Copy link
@dmatej

dmatej Jan 8, 2020

Contributor

Only a question: why you updated this copyright year?

This comment has been minimized.

Copy link
@pzygielo

pzygielo Jan 8, 2020

Author Contributor

I missed the one already in place, hidden at

// Portions Copyright [2016-2019] [Payara Foundation and/or its affiliates]

Have not revoked OCA, so it's still kind of true 😉 I think.

This comment has been minimized.

Copy link
@pzygielo

pzygielo Jan 8, 2020

Author Contributor

@dmatej I'm going to check my pending open PRs.

@pzygielo pzygielo deleted the pzygielo:debug branch Jan 8, 2020
@pzygielo

This comment has been minimized.

Copy link
Contributor Author

pzygielo commented Jan 9, 2020

Just for reference - one sonar finding fixed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.