CUSTCOM-264 Client mode debugging (server=no) doesn't work with JDK>=9

[jGauravGupta]

Description

This is a bug fix. Github ticket: #4619
Since Java 9 JDWP agent listens only local network interface by default so remote connections would be rejected. In this PR, If server mode is enabled then address port is prefixed with *: to enable remote connection. Unfortunately, the *: syntax is not backward compatible to Java 8 hence debug address requires an update on runtime.

Important Info

Testing

New tests

Payara/nucleus/admin/launcher/src/test/java/com/sun/enterprise/admin/launcher/JavaConfigTest.java

Lines 56 to 78 in 8dc6dd0

	@Test
	public void debugInClientMode() {
	String DEBUG_CONFIG = "-agentlib:jdwp=transport=dt_socket,address=9009,server=n,suspend=y";
	Map<String, String> config = new HashMap<>();
	config.put("debug-options", DEBUG_CONFIG);
	JavaConfig javaConfig = new JavaConfig(config);
	List<String> debugOptions = javaConfig.getDebugOptions();
	Assert.assertEquals(DEBUG_CONFIG, debugOptions.get(0));
	}
	@Test
	public void debugInServerMode() {
	String DEBUG_CONFIG = "-agentlib:jdwp=transport=dt_socket,address=9009,server=y,suspend=n";
	Map<String, String> config = new HashMap<>();
	config.put("debug-options", DEBUG_CONFIG);
	JavaConfig javaConfig = new JavaConfig(config);
	List<String> debugOptions = javaConfig.getDebugOptions();
	if (JDK.getMajor() >= 9) {
	Assert.assertEquals("-agentlib:jdwp=transport=dt_socket,address=*:9009,server=y,suspend=n", debugOptions.get(0));
	} else {
	Assert.assertEquals(DEBUG_CONFIG, debugOptions.get(0));
	}
	}

Testing Performed

Tested manually with IntelliJ IDEA 2020.1 patched with glassfishIntegration.jar on JDK8/11.

Testing Environment

Windows 10, JDK 11.0.3, JDK 1.8.0_172, IntelliJ IDEA 2020.1

[MattGill98]

jenkins test please

[pzygielo]

I suppose this broke displaying debug info on start-domain --debug=true as the host part *: is not recognized by the pattern searching for port (alone) in address.

• PAYARA-3577 Build Payara Server & Payara Micro using JDK8 and get them to pass the Test Suite #3905 was already there