Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Grizzly ALPN from 1.8.0u251 and above #4656

Merged
merged 1 commit into from
May 7, 2020
Merged

Remove Grizzly ALPN from 1.8.0u251 and above #4656

merged 1 commit into from
May 7, 2020

Conversation

MattGill98
Copy link
Contributor

Description

These versions also contain the ALPN functionality included in Java 9,
so should be treated as such by the domain options.

Fixes #4625

Testing

Testing Performed

JDK 1.8u154 SSL connection.

These versions also contain the ALPN functionality included in Java 9,
so should be treated as such by the domain options.

Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
@MattGill98 MattGill98 self-assigned this May 6, 2020
@MattGill98
Copy link
Contributor Author

jenkins test please

Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with

/usr/lib/jvm/jdk1.8.0/bin/java -version
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_252-b09)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.252-b09, mixed mode)

asadmin change-admin-password
asadmin enable-secure-admin
asadmin restart-domain
curl --insecure https://localhost:4848

No errors in server.log :)

Copy link
Contributor

@OndroMih OndroMih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is what I expected and tested earlier with Corretto 8.252 and it worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payara 5.201 will not start with Amazon Corretto 8.252.09.1 after enable-secure-admin command
3 participants