Fish 5702 improper limitation pathname restricted directory #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smillidge
reviewed
Sep 1, 2021
appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContextValve.java
Outdated
Show resolved
Hide resolved
OndroMih
suggested changes
Sep 1, 2021
appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContextValve.java
Outdated
Show resolved
Hide resolved
Pandrex247
requested changes
Sep 1, 2021
appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContextValve.java
Outdated
Show resolved
Hide resolved
OndroMih
approved these changes
Sep 2, 2021
appserver/web/web-core/src/test/java/org/apache/catalina/core/StandardContextValveTest.java
Outdated
Show resolved
Hide resolved
Pandrex247
approved these changes
Sep 2, 2021
appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContextValve.java
Outdated
Show resolved
Hide resolved
|
Jenkins test |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
…limitation-pathname-restricted-directory Fish 5702 improper limitation pathname restricted directory
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
…limitation-pathname-restricted-directory Fish 5702 improper limitation pathname restricted directory
breakponchito
deleted the
FISH-5702-improper-limitation-pathname-restricted-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding fix to solve problem to access Restricted Directory when using context root as /
Important Info
Blockers
Testing
New tests
Added new test: StandardContextValveTest.java
Testing Performed
I already tested this on local environment. Check the following comment from jira to verify results:
https://payara.atlassian.net/browse/FISH-5702?focusedCommentId=57244
Testing Environment
Documentation
Notes for Reviewers