Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5834 JBoss Logging 3.4.2 #5483

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

Pandrex247
Copy link
Member

Description

Upgrades JBoss Logging to a version required by Weld 3.1.8 - (weld upgrade required for JDK 17)

The imports in AppClientDeployerHelper were poked because they were a) importing unused classes b) some of those classes didn't exist anymore leading to compilation errors.

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Ran the following below on both JDK 8 and 11.
Started the admin console - no errors
Ran Payara Samples - no errors

Testing Environment

WSL OpenSUSE 15.3, Zulu JDK 8u312 & 11.0.13

Documentation

N/A

Notes for Reviewers

None

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247
Copy link
Member Author

Jenkins test please

1 similar comment
@Pandrex247
Copy link
Member Author

Jenkins test please

Copy link
Member

@JamesHillyard JamesHillyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright needs updating on:
appserver/appclient/server/core/src/main/java/org/glassfish/appclient/server/core/AppClientDeployerHelper.java

Other than that looks good, tested on Windows 10 JDK 8

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 merged commit e78eaf0 into payara:master Nov 3, 2021
@Pandrex247 Pandrex247 deleted the FISH-5834 branch November 3, 2021 09:33
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants