Fish 6759 search cdi manager via jndi #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
approved these changes
Sep 25, 2023
aubi
merged commit ad1075a
into
payara:security-soteria-1.1.payara-maintenance
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search for CDI doesn't work well in EAR packaging.
The current way searches through all modules, which can find the calling class. And because EJB module sees the WAR classes, it may be (and often is) chosen instead of the WAR, causing further CDI search failures.
This change mimics behavior of version 3, which uses tries to find "java:comp/BeanManager" in JNDI, which works more reliably.
I left a comment, so future change doesn't return to CDI.current().