Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

field.admin.disableListColumn has no effect if the field is nested inside a row field #6407

Closed
franciscolourenco opened this issue May 17, 2024 · 0 comments · Fixed by #6412
Closed

field.admin.disableListColumn has no effect if the field is nested inside a row field #6407

franciscolourenco opened this issue May 17, 2024 · 0 comments · Fixed by #6412
Assignees
@PatrikKozak
Labels
status: needs-triage Possible bug which hasn't been reproduced yet

Comments

@franciscolourenco
Copy link
Contributor

franciscolourenco commented May 17, 2024 •
edited
Loading

Link to reproduction

main...franciscolourenco:payload:reproduce-disable-list-column-inside-row

Describe the Bug

field.admin.disableListColumn has no effect if the field is inside of a row field. Looking at the code, I assume this might be a problem with all nested fields.

To Reproduce

Place a field inside of a row, and set admin.disableListColumn: true on that field.

image

Payload Version

2.18.2

Adapters and Plugins

No response
@franciscolourenco franciscolourenco added the status: needs-triage Possible bug which hasn't been reproduced yet label May 17, 2024
@franciscolourenco franciscolourenco changed the title field.admin.disableListColumn doesn't work if field is inside a row field field.admin.disableListColumn has no effect if the field is nested inside a row field May 17, 2024
@PatrikKozak PatrikKozak mentioned this issue May 17, 2024
Merged
4 tasks
denolfe pushed a commit that referenced this issue May 17, 2024
@PatrikKozak
fix: nested disableListColumn in rows (#6412)
ab8b2f3 
## Description

Fixes #6407 

- [x] I have read and understand the
[CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md)
document in this repository.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] Existing test suite passes locally with my changes
JessChowdhury pushed a commit that referenced this issue May 20, 2024
@PatrikKozak @JessChowdhury
fix: nested disableListColumn in rows (#6412)
224c17c 
## Description

Fixes #6407 

- [x] I have read and understand the
[CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md)
document in this repository.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] Existing test suite passes locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PatrikKozak PatrikKozak

Labels
status: needs-triage Possible bug which hasn't been reproduced yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: nested disableListColumn in rows payloadcms/payload
2 participants
@franciscolourenco @PatrikKozak