Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: format fields within tab for list controls #4516

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: format fields within tab for list controls #4516

merged 1 commit into from
Dec 15, 2023

Conversation

JessChowdhury
Copy link
Member

Description

Issue #4458 found that tab fields with hidden: true still show up in the list controls (column selector and filters). This PR updates the formatFields function to map over the tab fields.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JessChowdhury JessChowdhury mentioned this pull request Dec 15, 2023
Closed
@DanRibbens DanRibbens merged commit 2650c70 into main Dec 15, 2023
29 checks passed
@DanRibbens DanRibbens deleted the fix/hidden-tab-fields branch December 15, 2023 15:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRibbens DanRibbens DanRibbens approved these changes

@jmikrut jmikrut Awaiting requested review from jmikrut

@jacobsfletch jacobsfletch Awaiting requested review from jacobsfletch

@JarrodMFlesch JarrodMFlesch Awaiting requested review from JarrodMFlesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JessChowdhury @DanRibbens