Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(richtext-lexical)!: simplify creation of features #6885

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Jun 21, 2024

  • Adds new createServerFeature and createClientFeature helper functions to create new features without boilerplate.
  • Makes some props optional which were previously required
  • The feature prop, for both server & client features, now also accept normal objects. Functions are rarely need there

BREAKING:

  • ServerFeature: ClientComponent has been renamed to ClientFeature
  • ServerFeature: The nested serverFeatureProps has been renamed to sanitizedServerFeatureProps
  • ServerFeature: The FeatureProviderProviderServer type now expects 3 generics instead of 2. We have split the props generic into sanitized & unsanitized props
  • ClientFeature: The FeatureProviderProviderClient type now expects 2 generics instead of 1. We have split the props generic into sanitized & unsanitized props
  • ClientFeature: The nested clientFeatureProps has been renamed to sanitizedClientFeatureProps

@AlessioGr AlessioGr enabled auto-merge (squash) June 21, 2024 14:58
@AlessioGr AlessioGr merged commit d66b348 into beta Jun 21, 2024
46 checks passed
@AlessioGr AlessioGr deleted the feat/lexical-simplify-features branch June 21, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant