Fix issue with refunds #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review / merge this pull request, we have the same issue. |
|
Is anyone reviewing this PR? |
|
Hi @solilokiam, |
nikoloff
added a commit
that referenced
this pull request
Jan 7, 2015
remove type check for http response code
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve an issue we've been experiencing this week with the refunds. We don't know the reason but when making refunds with production enviroment it always throws a PaymillException. The funny part is that the expection has a 20000 response code.
We've been debugging the comunication between paymill api and our systems and we've realized that the response code was casted to string instead of integer. We've changed the strict type comparision in response handler.