Adding capability to specify sdk version / device variation via Webtest ... #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR include the changes @binhvu needs? |
|
@mach6 |
| public String getDevice() { | ||
| if (device.contains("android") || device.equalsIgnoreCase("iphone") || device.equalsIgnoreCase("ipad")) { | ||
| if (device.contains("android") || device.contains("iphone") || device.contains("ipad")) { | ||
| if (StringUtils.contains(device, ":")) { |
There was a problem hiding this comment.
Do we really need to use StringUtils.contains and StringUtils.split ? Can we not just use device.contains and device.split here ? I believe StringUtils basically shields you for null values, but if that were the case then the parent if condition itself would be throwing a NullPointerException because we have not shielded the code there.
There was a problem hiding this comment.
@krmahadevan good point. I'll add an NPE check and switch it to using device.contains/device.split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing ticket #53. Adding capabilities to allow a use to specify sdk / device variation