Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX implementation will break with go 1.6 #64

Open
raff opened this issue Feb 4, 2016 · 6 comments
Open

OSX implementation will break with go 1.6 #64

raff opened this issue Feb 4, 2016 · 6 comments

Comments

@raff
Copy link
Contributor

raff commented Feb 4, 2016

Go 1.6 has more restrictions in the use of cgo and Go pointers and the current implementation breaks in various places with various errors "panic: runtime error: cgo argument has Go pointer to Go pointer".

I have "fixed" my implementation with some casts (need to verify that it really works). See raff/goble@811260b

@emptyway
Copy link

emptyway commented Mar 4, 2016

I can confirm this issue.

@zubairhamed
Copy link

+1

2 similar comments
@anubhav-sri
Copy link

+1

@sleeper
Copy link

sleeper commented May 7, 2016

+1

roylee17 pushed a commit to currantlabs/gatt that referenced this issue Jun 11, 2016
bunch of ugly type casting to "fix" problems with Go 1.6 "Go pointer
@ghost
Copy link

ghost commented Jul 2, 2016

It seems like there might be an error when trying to connect my OnePlus X to my Mac Mini with server.go (example). The phone never connects properly returning the "incorrect passkey" error regardless of the password typed.

@tolleiv
Copy link

tolleiv commented Aug 15, 2016

The changes made by @roylee17 solve this issue for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants