Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Indications Support for Linux implementation #31

Merged
merged 2 commits into from
Apr 22, 2015

Conversation

demon-xxi
Copy link
Contributor

Please review my changes and consider merging into your repo.

Added new method Peripheral.SetIndicateValue to subscribe for gatt indications similar to notifications. For Indications though we need to send acknowledgment which is done by

p.l2c.Write([]byte{attOpHandleCnf})

Current pr contains only linux implementation. Darwin version needs more investigation as seems less documented and uses some hard-coded values instead of constants.

@roylee17
Copy link
Contributor

Looks good to me for the linux implementation.
To make it an API available for users, you might want to:

  • Add it to the interface in peripheral.go, Nice doc comment (with notes of the difference/status between Linux and Darwin).
  • Add a place holder (a working version, even better) for Darwin version in peripheral_darwin.go.

Thanks a lot.

Roy

@demon-xxi
Copy link
Contributor Author

Good catch Roy, I will do updates today.

@demon-xxi
Copy link
Contributor Author

I've added method to interface and a placeholder for darwin.
Also crated issue #32 to address that and the note in readme.md file. Will definitely get back to tat one when have some spare time. Seems easy to do but need to test carefully.

roylee17 added a commit that referenced this pull request Apr 22, 2015
Added Indications Support for Linux implementation
@roylee17 roylee17 merged commit f93da80 into paypal:master Apr 22, 2015
@roylee17
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants