This repository has been archived by the owner on Jan 22, 2020. It is now read-only.
Cleanup. #19
Open
Cleanup. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,8 +62,8 @@ var NemoGenerator = yeoman.generators.Base.extend({ | |||
| fs.writeFileSync('Gruntfile.js', gruntContent); | |||
| } | |||
| //let's update Gruntfile.js if possible | |||
| var gruntfileData = fs.readFileSync('Gruntfile.js'), | |||
| output = gruntFileApi.init(gruntfileData); | |||
| var gruntfileData = fs.readFileSync('Gruntfile.js'); | |||
There was a problem hiding this comment.
I would say, if you are going to remove this grouped var declaration, please can you do the same throughout this file?
|
What would make this a valuable PR, in my opinion, would be if you could go through and hoist any hanging |
variable renaming. comment removal. readability touchups.
|
Sorry for late response; got busy with PPWC. |
Merging two separate code branching ifs. Creating cleaner copy functions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In app/index.js:
variable renaming.
comment removal.
readability touchups.