Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use qualified path for go mod #123

Merged

Conversation

Ahmadkashif
Copy link
Contributor

Solves #113

@Ahmadkashif
Copy link
Contributor Author

@varuntechie Hi,

I can see builds failing, I'll try to fix this if this is halting the resolution of this issue.

@NeetishPathak
Copy link
Collaborator

Build to be fixed. Also please make the changes in the dev branch directly and raise a PR.

@Ahmadkashif
Copy link
Contributor Author

Hi @NeetishPathak @varuntechie , I have fixed both builds locally, should work fine here as well.

@Ahmadkashif
Copy link
Contributor Author

Hi @NeetishPathak , @varuntechie

What else can I do to move this PR forward?

@Ahmadkashif
Copy link
Contributor Author

Hi @NeetishPathak , @varuntechie

I have resolved conflicts as well. What can I do to move this forward?

@NeetishPathak NeetishPathak merged commit 11e5598 into paypal:dev May 21, 2024
1 of 4 checks passed
Copy link
Collaborator

@NeetishPathak NeetishPathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants