Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds QRcode Interface/Zoid Component functionality #1632

Merged
merged 3 commits into from
May 13, 2021

Conversation

BriceShatzer
Copy link
Contributor

Adds the zoid component & interface portion of the QRCode UI component being added to SPB here:
https://github.com/paypal/paypal-smart-payment-buttons/pull/158

@BriceShatzer BriceShatzer requested a review from a team as a code owner May 12, 2021 16:37
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #1632 (4c5c3c4) into master (4885982) will increase coverage by 1.96%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
+ Coverage   48.51%   50.48%   +1.96%     
==========================================
  Files          85       90       +5     
  Lines        1076     1143      +67     
  Branches      166      168       +2     
==========================================
+ Hits          522      577      +55     
- Misses        491      505      +14     
+ Partials       63       61       -2     
Impacted Files Coverage Δ
src/zoid/qr-code/component.jsx 13.04% <13.04%> (ø)
src/interface/button.js 96.55% <100.00%> (+0.25%) ⬆️
src/zoid/buttons/component.jsx 83.07% <0.00%> (ø)
src/zoid/fields/container.jsx 77.27% <0.00%> (ø)
src/zoid/fields/prerender.jsx 100.00% <0.00%> (ø)
src/interface/fields.js 100.00% <0.00%> (ø)
src/zoid/fields/component.jsx 100.00% <0.00%> (ø)
src/ui/buttons/props.js 76.19% <0.00%> (+0.80%) ⬆️
src/funding/funding.js 72.72% <0.00%> (+2.27%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4885982...4c5c3c4. Read the comment docs.

@mstuart
Copy link
Contributor

mstuart commented May 13, 2021

👍

Copy link
Contributor

@bluepnume bluepnume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mstuart mstuart merged commit 184dc26 into paypal:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants