Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update Calculator to show error when below/above threshold is met #1097

Merged
merged 5 commits into from
May 28, 2024
Merged

refactor: Update Calculator to show error when below/above threshold is met #1097

merged 5 commits into from
May 28, 2024

Conversation

perco12
Copy link
Contributor

@perco12 perco12 commented May 21, 2024 •
edited
Loading

Description

Update the calculator to not show the amounts if below/above error threshold is met.

Screenshots

Testing instructions

@yeul yeul added the snapshots Trigger new snapshots to be generated label May 28, 2024
@yeul yeul removed the snapshots Trigger new snapshots to be generated label May 28, 2024
@perco12 @yeul
Update src/components/modal/v2/parts/Calculator.jsx to always show an…
187b327 
…d not only on error

Co-authored-by: Julia F. <mpscqw@gmail.com>
@perco12 perco12 added the snapshots Trigger new snapshots to be generated label May 28, 2024
@perco12 perco12 removed the snapshots Trigger new snapshots to be generated label May 28, 2024
@danzhaaspaypal danzhaaspaypal merged commit 53ed327 into paypal:develop May 28, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@semantic-release-bot
chore(release): 1.64.5 [skip ci]
b5f6161 
### [1.64.5](v1.64.4...v1.64.5) (2024-05-28)

### Code Refactoring

* Update Calculator to show error when below/above threshold is met ([#1097](#1097)) ([53ed327](53ed327))

### Continuous Integration

* split tests ([#1090](#1090)) ([b49c74a](b49c74a))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.64.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@perco12 perco12 deleted the jolly-jack-juggles-jellybeans branch August 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeul yeul yeul approved these changes

Assignees
No one assigned
Labels
approved released testing complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perco12 @yeul @danzhaaspaypal