#431 CustomTestKit default config scans base config for listeners... #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akara
commented
Mar 22, 2017
| |} | ||
| """.stripMargin + portOverrides | ||
| ) | ||
| } |
There was a problem hiding this comment.
Note: Since the test already tests "default-listener" which is the result of the listener scan, this change is already tested with the current tests. No new tests needed.
anilgursel
reviewed
Mar 23, 2017
docs/testing.md
Outdated
| @@ -108,7 +108,7 @@ Please note, `CustomTestKit` allows passing `config` and `resources` together as | |||
|
|
|||
| #### Port binding in tests | |||
|
|
|||
| Starting services requires port binding. To prevent port conflicts, we should let the system pick a port by setting listeners' `bind-port` to 0, e.g., `default-listener.bind-port = 0` (this is what `CustomTestKit` sets by default). `squbs-testkit` comes with a `trait` named `PortGetter` that allows retrieving the port picked by the system. `CustomTestKit` comes with `PortGetter` already mixed in, so you can use `port` value. | |||
| Starting services requires port binding. To prevent port conflicts, we should let the system pick a port by setting listeners' `bind-port` to 0, e.g., `default-listener.bind-port = 0` (`CustomTestKit` sets `bind-port = 0` for all listeners with the default configuration). `squbs-testkit` comes with a `trait` named `PortGetter` that allows retrieving the port picked by the system. `CustomTestKit` comes with `PortGetter` already mixed in, so you can use `port` value. | |||
There was a problem hiding this comment.
(
CustomTestKitsetsbind-port = 0for all listeners with the default configuration).
This sentence can be made little more clear. It sounds like "with the default configuration" is for "all listeners" while you are referring to CustomTestKit's default configuration. How about the following?
CustomTestKit, if used with default configuration, sets bind-port = 0 for all listeners.
|
Minor doc comment, otherwise LGTM |
… assign port to 0 for all by default to avoid any listener port conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and assign port to 0 for all by default to avoid any listener port conflict.
Thanks for your pull request. Please review the following guidelines.