Support custom config and simplify environment selection #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way that the environment (staging vs prod vs perf) is configured, and also enables custom environment configuration (Fixes #500).
The constructor for the internal class
Conf
is modified in a breaking way, however it is unlikely that this class was used by any consumers.Previously, Boolean flags
productionMode
andperfMode
could be used to pick one of three environments. Now, a string environment name ("PROD"
,"STAGING"
, or"PERF_MODE"
) can be used, or a custom instance of theConf
class. The old flags also remain, for backwards compatibility, but the documentation has been updated to show the new method.New Feature Submissions:
Changes to Core Features: