Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom config and simplify environment selection #504

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

curtisfennerpaypay
Copy link
Contributor

This PR simplifies the way that the environment (staging vs prod vs perf) is configured, and also enables custom environment configuration (Fixes #500).

The constructor for the internal class Conf is modified in a breaking way, however it is unlikely that this class was used by any consumers.

Previously, Boolean flags productionMode and perfMode could be used to pick one of three environments. Now, a string environment name ("PROD", "STAGING", or "PERF_MODE") can be used, or a custom instance of the Conf class. The old flags also remain, for backwards compatibility, but the documentation has been updated to show the new method.

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #504 into master will not change security risk.

Click here to see full report

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chao-chang-paypay chao-chang-paypay merged commit 918514c into master Jun 14, 2022
@chao-chang-paypay chao-chang-paypay deleted the curtisfennerpaypay-allow-custom-conf branch June 14, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom endpoint url
2 participants