Added additional test coverage

paypay · Sep 29, 2020 · 8e1356b · 8e1356b
1 parent 2639859
commit 8e1356b
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 7 deletions.
diff --git a/tests/ContinuousPaymentTest.php b/tests/ContinuousPaymentTest.php
@@ -1,6 +1,7 @@
 <?php
 
 use PayPay\OpenPaymentAPI\Models\CreateContinuousPaymentPayload;
+use PayPay\OpenPaymentAPI\Models\ModelException;
 
 require_once('TestBoilerplate.php');
 final class ContinuousPaymentTest extends TestBoilerplate
@@ -57,4 +58,13 @@ public function testCreateAndCancel()
         $this->Create();
         $this->Cancel();
     }
+    public function testBadPayloadFailure()
+    {
+        try {
+            $this->client->payment->createContinuousPayment(2);
+        } catch (ModelException $e) {
+            $this->assertStringContainsString("Payload not of type CreateContinuousPaymentPayload",$e->getMessage());
+        }
+
+    }
 }
diff --git a/tests/PaymentTest.php b/tests/PaymentTest.php
@@ -10,18 +10,18 @@ final class PaymentTest extends TestBoilerplate
      *
      * @return void
      */
-    public function Create()
+    public function Create($similar=false)
     {
         $client = $this->client;
         $CPPayload = new CreatePaymentPayload();
         // Save Cart totals
         $amount = [
-            "amount" => 12,
+            "amount" => $similar?12:rand(5,10),
             "currency" => "JPY"
         ];
         $CPPayload->setMerchantPaymentId(uniqid('TESTMERCH_PAY_ID'))->setRequestedAt()->setUserAuthorizationId($this->config['uaid'])->setAmount($amount);
         // Get data for QR code
-        $resp = $client->payment->createPayment($CPPayload,true);
+        $resp = $client->payment->createPayment($CPPayload,$similar);
         $resultInfo = $resp['resultInfo'];
         $this->assertEquals('SUCCESS', $resultInfo['code']);
         $data = $resp['data'];
@@ -52,5 +52,7 @@ public function testCreateAndCancel()
     {
         $this->Create();
         $this->Cancel();
+        $this->Create(true);
+        $this->Cancel();
     }
 }
diff --git a/tests/PendingPaymentTest.php b/tests/PendingPaymentTest.php
@@ -1,6 +1,7 @@
 <?php
 
 use PayPay\OpenPaymentAPI\Models\CreateContinuousPaymentPayload;
+use PayPay\OpenPaymentAPI\Models\ModelException;
 use PayPay\OpenPaymentAPI\Models\RefundPaymentPayload;
 
 require_once 'TestBoilerplate.php' ;
@@ -122,4 +123,13 @@ public function testRefund()
         $this->refund();
         $this->refundDetails();
     }
+    public function testBadPayloadFailure()
+    {
+        try {
+            $this->client->payment->createPendingPayment(2);
+        } catch (ModelException $e) {
+            $this->assertStringContainsString("Payload not of type CreatePendingPaymentPayload",$e->getMessage());
+        }
+
+    }
 }
diff --git a/tests/PreAuthTest.php b/tests/PreAuthTest.php
@@ -10,14 +10,14 @@ class PreAuthTest extends TestBoilerplate
 {
 
 
-    public function Create()
+    public function Create($similiar=true)
     {
         $CPApayload = new CreatePaymentAuthPayload();
         $CPApayload->setMerchantPaymentId(uniqid('TEST_PREAUTH'))
             ->setUserAuthorizationId($this->config['uaid'])
-            ->setAmount(['amount' => 20, 'currency' => 'JPY'])
+            ->setAmount(['amount' => $similiar?20:rand(5,17), 'currency' => 'JPY'])
             ->setRequestedAt();
-        $resp = $this->client->payment->createPaymentAuth($CPApayload, true);
+        $resp = $this->client->payment->createPaymentAuth($CPApayload, $similiar);
         var_dump($resp);
         $this->assertTrue(isset($resp['resultInfo']));
         $this->assertEquals('SUCCESS', $resp['resultInfo']['code'], $resp['resultInfo']['message'] );
@@ -85,7 +85,7 @@ public function testPreauthCapture()
      */
     public function testPreauthRevert()
     {
-        $this->Create();
+        $this->Create(false);
         $this->RevertAuthorization();
     }
 }