Hide unsused payment options on subscriptions, Add log in instructions for non logged in customers #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding add card for all users so it can be used for recurring payments etc.
Also hide unsused payment options when using subscription payments
loueranta-paytrail
requested changes
Aug 22, 2022
| @@ -339,6 +339,10 @@ msgstr "toimitus" | |||
| msgid "An error occurred validating the signature." | |||
| msgstr "Allekirjoituksen vahvistamisessa tapahtui virhe." | |||
|
|
|||
| #: src/Gateway.php:1117 | |||
| msgid "You can save your card details for next time by logging in to the store. If you do not own an account you can also create one." | |||
There was a problem hiding this comment.
Saisiko tähän tekstiin linkin kirjautumissivulle tuosta "logging in"-kohdasta ja rekisteröitymissivulle tuosta "create one"-kohdasta?
Ja ehkä käännös voisi olla "If you don't have an account, you can create one."
src/Gateway.php
Outdated
| 'save_card_text_selection' => [ | ||
| 'title' => __( 'Saving card description', 'paytrail-for-woocommerce' ), | ||
| 'type' => 'checkbox', | ||
| 'label' => __( 'Enable enable "you save card details by logging in" text for customer without an account', 'paytrail-for-woocommerce' ), |
There was a problem hiding this comment.
Pitäisi varmaan olla "you can save..."
There was a problem hiding this comment.
Ja olikos muuten näille hallintasivun teksteille olemassa käännökset suomeksi?
loueranta-paytrail
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tickets & documents
Link to JIRA ticket if there is one.
Description
Provide a meaningful description about the changes you've made.