Use python gpg #906
Use python gpg #906
Conversation
|
thanks. Do you know if this ships with / is supported by majour distributions?
Quoting dkg (2016-11-30 07:44:23)
… GnuPG upstream is now producing a python module named "gpg", which is now
shipping as part of the gpgme library. It should get all improvements to
gpgme automatically as gpgme is updated.
The pygpgme package is maintained by a third party and is not keeping up
with newer versions of either GPGME or GnuPG itself.
Converting to python-gpg should be an improvement.
--------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
[1]#906
Commit Summary
* convert from pygpgme to the python "gpg" module
* just use the OpenPGP fingerprint instead of inventing "hash_key"
File Changes
* M [2]alot/commands/envelope.py (2)
* M [3]alot/commands/utils.py (6)
* M [4]alot/crypto.py (113)
* M [5]alot/db/envelope.py (8)
* M [6]alot/db/utils.py (2)
* M [7]alot/settings/checks.py (2)
* M [8]docs/source/conf.py (2)
* M [9]docs/source/installation.rst (6)
* M [10]setup.py (2)
Patch Links:
* [11]https://github.com/pazz/alot/pull/906.patch
* [12]https://github.com/pazz/alot/pull/906.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [13]view it on GitHub, or [14]mute the
thread.
Reverse link: [15]unknown
References
Visible links
1. #906
2. https://github.com/pazz/alot/pull/906/files#diff-0
3. https://github.com/pazz/alot/pull/906/files#diff-1
4. https://github.com/pazz/alot/pull/906/files#diff-2
5. https://github.com/pazz/alot/pull/906/files#diff-3
6. https://github.com/pazz/alot/pull/906/files#diff-4
7. https://github.com/pazz/alot/pull/906/files#diff-5
8. https://github.com/pazz/alot/pull/906/files#diff-6
9. https://github.com/pazz/alot/pull/906/files#diff-7
10. https://github.com/pazz/alot/pull/906/files#diff-8
11. https://github.com/pazz/alot/pull/906.patch
12. https://github.com/pazz/alot/pull/906.diff
13. #906
14. https://github.com/notifications/unsubscribe-auth/AAmW579YPIog6V49YIq5jBpg9T3MNj39ks5rDSlXgaJpZM4K_5Rc
15. #906
|
|
sure, python-gpg 1.8.0 is in debian unstable now, and i intend it to ship with stretch (i'm part of debian's pkg-gnupg-maint team). |
|
Thanks for the clarification. I'll try this soon, and will await some
more comments re packaging in other distributions.
Quoting dkg (2016-11-30 12:33:11)
… sure, python-gpg 1.8.0 is in debian unstable now, and i intend it to ship
with stretch (i'm part of debian's pkg-gnupg-maint team).
—
You are receiving this because you commented.
Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.
Reverse link: [3]unknown
References
Visible links
1. #906 (comment)
2. https://github.com/notifications/unsubscribe-auth/AAmW5zhm20ahPXmdfciTSE6SLzhcd3UVks5rDW0HgaJpZM4K_5Rc
3. #906 (comment)
|
| @@ -32,6 +32,6 @@ | |||
| 'twisted>=10.2.0', | |||
| 'python-magic', | |||
| 'configobj>=4.7.0', | |||
| 'pygpgme>=0.2'], | |||
| 'gpg'], | |||
There was a problem hiding this comment.
is there a minimal required version#?
There was a problem hiding this comment.
I don't think there is -- but in any case, 1.8.0 is the first fully-supported upstream release of python-gpg that exists anywhere, so i think it's safe to not indicate a version number.
|
I like the fact that this cleans up a lot of the cluttered code. Its a nice patch :) How would i test this on debian testing? |
|
You can install python-gpg from unstable. It is built from the gpgme1.0 source package, which should have migrated by now, but is apparently blocked due to https://bugs.debian.org/846232 I'll upload a new version to unstable shortly to try to unblock that bug in hopes that it will migrate soon. |
|
Ftr: afaik @teythoon built the the pypi/pip package, so he should know details ;) |
|
I did, and I am also maintaining the bindings upstream. I support this change :) |
|
OK, I've decided not to push this before the upcoming release so that v0.3.8 can more easily make it into debian stable soon. |
|
rebased: #915. closing this here |
| try: | ||
| return ctx.verify(signature_data, message_data, None) | ||
| except gpgme.GpgmeError as e: | ||
| (data, verify_results) = ctx.verify(gpg.Data(string=message), gpg.Data(string=signature), message_data) |
There was a problem hiding this comment.
The code has since changed in master.
GnuPG upstream is now producing a python module named "gpg", which is now shipping as part of the gpgme library. It should get all improvements to gpgme automatically as gpgme is updated.
The pygpgme package is maintained by a third party and is not keeping up with newer versions of either GPGME or GnuPG itself.
Converting to python-gpg should be an improvement.