-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect loading of object property named default
#5
Comments
Hi Daniel. I know Restish well! Thanks for stopping by. I'll look into this ASAP The library is super new, so I know I've missed a few things like this. Appreciate the feedback and for helping me make this library better. |
After investigating, I realized this was a bug I fixed a few days ago, but it's sitting in a feature branch that's not quite ready, it's stable and entirely usable, but there are some minimal breaking changes in it. I'm close to having this feature ready (I need to bump coverage back up in some low-level models). You are free to use that branch (which isn't going to change much more now that it's 95% ready). I'll be able to merge in the what-changed feature in a week or so, providing I stay on schedule The branch is called |
This fix has been merged into main, but the 1.2 release is not yet ready. There needs some more stress testing and fixes made on the what-changed feature. Once it's able to cope with some load and stress, I will create the 1.2 tag. There are a few minor breaking changes, which I will document, but nothing major and nothing that has many effects beyond the low-level API. |
v0.2.0 is now available with this fix in place. Thank you for helping me make this a better tool. |
Hi 👋 I'm the author of Restish and am working on adding OpenAPI 3.1 support. First off - awesome project and thanks for taking the time to write this library! Migrating from kin-openapi to libopenapi has been mostly straightforward so far.
I ran into an interesting bug where JSON schemas with objects defined that have a property named
default
seem to get set as the*base.Schema.Default
field when it should be eithernil
or the actual default. Here's a simple example that when run outputs the following:Here is the code. I would link to the Go playground but it times out, so you'll have to run locally.
The text was updated successfully, but these errors were encountered: