-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: OpenAPI 3.1 support, fixes #115 #145
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 66.22% 73.78% +7.55%
==========================================
Files 22 22
Lines 2594 2823 +229
==========================================
+ Hits 1718 2083 +365
+ Misses 698 583 -115
+ Partials 178 157 -21
Continue to review full report at Codecov.
|
This library returns errors for circular references here: Line 513 in c145bbb
Restish then proceeds to panic on these. Unfortunately this breaks restish for all our APIs :-( Looking at the libopenapi source code, it seems like the circular reference errors can be detected with |
For future reference, @wdullaer's comment above was addressed in pb33f/libopenapi#39 and then in #151, which has now been released in https://github.com/danielgtaylor/restish/releases/tag/v0.15.1. |
This PR implements OpenAPI 3.1 support by switching to https://github.com/pb33f/libopenapi as the underlying Golang OpenAPI library. Every effort is being made to make this a backward-compatible change, however it's possible something may break or change slightly. Included with this change are:
allOf
,anyOf
,oneOf
Related upstream issues:
default
pb33f/libopenapi#5X-
are mistakenly ignored pb33f/libopenapi#24