Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with zero value in the setDimensions function #29

Merged
merged 2 commits into from
Dec 18, 2012
Merged

Fixed issue with zero value in the setDimensions function #29

merged 2 commits into from
Dec 18, 2012

Conversation

vermilion1
Copy link
Contributor

Previously, you couldn't set a zero value to the variable

@swernerx
Copy link
Contributor

Thanks for the report. Would prefer the use of "!= null" though.

@Prinzhorn
Copy link

Or maybe if(clientWidth === +clientWidth) to accept all numbers?

saschagoebel added a commit that referenced this pull request Dec 18, 2012
@saschagoebel
Merge pull request #29 from vermilion1/master
9029ce5 
Fixed issue with zero value in the setDimensions function
@saschagoebel saschagoebel merged commit 9029ce5 into pbakaus:master Dec 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vermilion1 @swernerx @Prinzhorn @saschagoebel