forked from idaholab/moose
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix for signal checkpoint writing unconverged soln
This commit patches the issue (idaholab#25755) where a checkpoint can write an unconverged solution depending on when the USR1 signal is received, thereby affecting the accuracy of recovered simulations. The fix 1) adds logic that ensures a checkpoint is not output unless _current_execute_flag is contained in _execute_on, and 2) enforces that Checkpoint’s ‘execute_on’ parameter may only be set to ‘TIMESTEP_END’ so that only converged solutions are output. Exodiff tests are added to ensure that simulations recovered from signal-based checkpoints result in the same solutions as the uninterrupted simulations.
- Loading branch information
Showing
5 changed files
with
66 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+88.6 KB
test/tests/misc/signal_handler/gold/simple_transient_diffusion_scaled_dbg.e
Binary file not shown.
Binary file added
BIN
+771 KB
test/tests/misc/signal_handler/gold/simple_transient_diffusion_scaled_out.e
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters