-
-
Notifications
You must be signed in to change notification settings - Fork 410
-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test sprint] Big files editor freeze, ram eating, wrong config after app kill. #1025
Comments
Thank you for our detailed report! But most of the things like the editor, undo/redo and clipboard are handled by the Qt framework directly and you would need to file bugs there... |
Can you make out what part of the config made your app not starting again? |
This one |
Thank you, seems to be a problem of the external library https://github.com/pbek/QOwnNotes/tree/develop/src/libraries/singleapplication. |
Checked memory again, every switch between big notes eats small amount of ram. |
I am all open for Pull Request |
Added big markdown file I used for testing. |
18.09.3
|
As for testing with 32MB markdown files... I wonder that you have even manage to open such a big text file in QOwnNotes... It took quite a while even on a SSD. |
There now is a new release, could you please test it and report if it works for you? |
I will test it tomorrow.
As I think the only way to improve this it to completely rewrite editor with MVC pattern. Render every line separately as view. And don't load the whole file but only beginning, load new file part when users need it (scrolls near it beginning or searching ... etc) and unloading unused parts. There will be lots of work... undo-redo, full-text search in file... and some more. Not Expected to be fixed soon. |
Single application mode now works fine for me. Tested latest appimage.
It's only 35mb it should be loaded to memory in less than 1 second... |
all note files are loaded into an in-memory sqlite database in the beginning. if the note is opened the note's text is loaded in a QPlainTextEdit
I don't think that isn't the issue, I think the issue is editing so much text in a QPlainTextEdit |
@fodrice did 18.09.3 bring any improvement with application locking after a crash? |
Yes. Now it works fine. |
Thank you for testing! Since I cannot do much about the other stuff I will close this for now... |
Long story short:
Make note. Copy paste big file (E. G 200 page file from libreoffice) then paste again, and again, go on 10-20 times. Ram consumption will rise to some big value (3 gb for me) and than everything freezes. It will unfreeze later but memory consumption remains at some big value.
After app shutdown it's freeze when I trying open created file (memory consumption is about 450m)
Also somehow after next shutdown after freeze I can't launch it any more /usr/bin/QOwnNotes just do nothing without any error message. Removing conf file from /home allowed to launch it again.
So there is a few bugs:
There is a memory leak when copy text from clipboard.
The whole notes file loads to memory that causes troubles with big files and troubles with the editor. It freezes when processing the really big file (tested on 50 mb markdown file).
It seems the app didn't unload notes from memory (e g when switched to another note). Previous should be saved and freed from memory after autosave period. Testing with 7 mb markdown file shows that data loaded but not unloaded when switched to another notes file. Memory consumption just raised from 25mb to 100mb.
You could use this file for memory check
Elephants killing markdown editors.zip
Nothing happens on crash with somehow made .conf file
QOwnNotes.conf.zip
Possible fix for 2 and 3:
Fix for 4:
Store last file/session info and settings separately. To avoid config corruption.
system info
QOwnNotes Version 18.09.2
Qt Version 5.9.6
Desktop environment: KDE
gentoo-linux 4.14.67
The text was updated successfully, but these errors were encountered: