New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug code block font-size in editor #826

Closed
zmni opened this Issue Jan 7, 2018 · 20 comments

Comments

Projects
None yet
2 participants
@zmni

zmni commented Jan 7, 2018

qon

Expected behaviour

Font size doesn't changed

Actual behaviour

Font size changed

Steps to reproduce

Just create like above gif, and play with it

Output from the debug section in the settings dialog

https://gist.github.com/zmni/a7669ee9cfe8a5dfb73e69e5a73b8946

Relevant log output (you have to enable enable the log widget)

https://gist.github.com/zmni/a7669ee9cfe8a5dfb73e69e5a73b8946

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2018

Can you please describe what you were actually doing? :)

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2018

And can you please paste your note, in case the text to test is relevant.

@zmni

This comment has been minimized.

zmni commented Jan 8, 2018

OK. 😅

  1. Create new note.
  2. Create code block.
  3. Paste any text (it's irrelevant).
  4. Press backspace and enter anywhere in the text.

When you press enter, the font size of the paragraph below current line shrink and the highlight changed. And when you fix that line, the font-size below that line shrink and the highlight changed. And so on.

The video of the whole process: https://streamable.com/zdihd

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2018

I cannot reproduce that under Windows 8 (nor Linux or mac OS), strange...

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2018

And I cannot reproduce that under Windows 10 neither... :(
The highlighting didn't change for me.

@zmni

This comment has been minimized.

zmni commented Jan 8, 2018

I just reset everything and start fresh. This problem start to happened after changing the editor font size on setting window to other larger than default value. And it's gone when I reset back to default value.

Also it's crashing (only once everytime I start fresh), it just happened when I navigate through my note. Is there any argument or flag to activate debug on launch?

@zmni

This comment has been minimized.

zmni commented Jan 8, 2018

After playing with any combination font-family/font-size setting, I also got issue with the headline font-size, it's flashing changing sizes rapidly and than it settle. Like the headline confused with its own font size. Because of that headline issue, if you navigate through notes to fast, QOwnNotes crash.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2018

After increasing the font-size I could reproduce your Font size changed issue, but only under Windows...
I even got the headline-issue, again just under Windows.
Could you please test the previous release for those issues?
https://ci.appveyor.com/api/buildjobs/xq32ka8efy63ymds/artifacts/appveyor%2FQOwnNotes.zip

@zmni

This comment has been minimized.

zmni commented Jan 8, 2018

Build 3421, 3422 (above) also have this issue. Build 3415 doesn't have this issue.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2018

Ok, thank you. Then most likely I will be able to fix that!

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2018

18.01.2

  • attempted to fix drawing problems in the note edit widget and possible crashes in Windows

There now is a new release, could you please test it and report if it works for you?

@pbek pbek added this to the 18.01.2 milestone Jan 10, 2018

@zmni

This comment has been minimized.

zmni commented Jan 11, 2018

Not yet. issues still occur. https://streamable.com/rqdz7

@pbek

This comment has been minimized.

Owner

pbek commented Jan 11, 2018

that's very strange, thank you for testing

@pbek

This comment has been minimized.

Owner

pbek commented Jan 11, 2018

@zmni

This comment has been minimized.

zmni commented Jan 11, 2018

Yes, it did work with b3415: https://streamable.com/ok6et

@pbek

This comment has been minimized.

Owner

pbek commented Jan 11, 2018

thank you for testing, I hope that not the new Qt version in the latest release is the problem :/

@pbek

This comment has been minimized.

Owner

pbek commented Jan 13, 2018

I can't reproduce it on my Windows Dev System, but I tried some more things.

18.01.3

  • fixed the disabling of the markdown highlighting
  • attempted to fix drawing problems in the note edit widget and possible
    crashes in Windows
@pbek

This comment has been minimized.

Owner

pbek commented Jan 13, 2018

There now is a new release, could you please test it and report if it works for you?

@zmni

This comment has been minimized.

zmni commented Jan 13, 2018

Yes finally, latest build fixed all issues. Thanks a lot @pbek.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 13, 2018

phew, finally. thank you for testing!
I almost feared it's a Qt 5.9 thing...

@pbek pbek closed this Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment