-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements for navigation parsing widget #1553
Conversation
Waqar144
commented
Jan 7, 2020
- Navigation parsing now runs concurrently, so that it doesn't block the UI.
- Navigation parsing widget only refreshes if there was some change in the document structure.
- Remove excess regexes as those don't seem necessary.
Awesome! |
This PR seems to break the AppImage OBS build: https://build.opensuse.org/package/live_build_log/home:pbek:QOwnNotes/desktop/AppImage/x86_64 I hope note more build systems will break. 😬 |
It will break. QT += concurrent |
Nothing else broke and I don't understand why. https://launchpad.net/~pbek/+archive/ubuntu/qownnotes/+packages went through too... |
But TravisCI tests are failing!?
Did you make a test |
I'll adapt everything. |
Strange, AppImage is still broken. https://build.opensuse.org/package/live_build_log/home:pbek:QOwnNotes/desktop/AppImage/x86_64 How can they not have |
Did 9a090f0 work? |
Didn't make a new release yet with it. Don't bother, I'll take care of it. 😁 |
Works |