Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements for navigation parsing widget #1553

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

Waqar144
Copy link
Contributor

@Waqar144 Waqar144 commented Jan 7, 2020

  • Navigation parsing now runs concurrently, so that it doesn't block the UI.
  • Navigation parsing widget only refreshes if there was some change in the document structure.
  • Remove excess regexes as those don't seem necessary.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 12.512% when pulling 2c219cc on Waqar144:nav-thread into adb099b on pbek:develop.

@pbek pbek merged commit bf52c26 into pbek:develop Jan 7, 2020
@pbek
Copy link
Owner

pbek commented Jan 7, 2020

Awesome!

@Waqar144 Waqar144 deleted the nav-thread branch January 7, 2020 13:31
pbek added a commit that referenced this pull request Jan 7, 2020
@pbek
Copy link
Owner

pbek commented Jan 7, 2020

This PR seems to break the AppImage OBS build: https://build.opensuse.org/package/live_build_log/home:pbek:QOwnNotes/desktop/AppImage/x86_64

I hope note more build systems will break. 😬

@Waqar144
Copy link
Contributor Author

Waqar144 commented Jan 7, 2020

This PR seems to break the AppImage OBS build: https://build.opensuse.org/package/live_build_log/home:pbek:QOwnNotes/desktop/AppImage/x86_64

I hope note more build systems will break. grimacing

It will break.
I think we need to do:

QT += concurrent

@pbek
Copy link
Owner

pbek commented Jan 7, 2020

Nothing else broke and I don't understand why.

https://launchpad.net/~pbek/+archive/ubuntu/qownnotes/+packages went through too...

@pbek
Copy link
Owner

pbek commented Jan 7, 2020

But TravisCI tests are failing!?
https://travis-ci.org/pbek/QOwnNotes/builds/633815466

QWARN  : TestNotes::testNoteDecryptionFail() [Botan Error]  Invalid CBC padding
QWARN  : TestNotes::testNoteDecryptionFail() Invalid version or not a cyphertext.
PASS   : TestNotes::testNoteDecryptionFail()
QDEBUG : TestNotes::testNoteToMarkdownHtml() cloudConnection:  CloudConnection: <id>1 <name>"Default" <serverUrl>"" <username>"" <priority>1
FAIL!  : TestNotes::testNoteToMarkdownHtml() 'html == expectedHtml' returned FALSE. ()
   Loc: [testcases/app/test_notes.cpp(129)]

Did you make a test testNoteToMarkdownHtml that expects a byte-matching html. (I changed the CSS today). Isn't that test a bit too much?

@pbek
Copy link
Owner

pbek commented Jan 8, 2020

I'll adapt everything.

pbek added a commit that referenced this pull request Jan 8, 2020
pbek added a commit that referenced this pull request Jan 8, 2020
@pbek
Copy link
Owner

pbek commented Jan 8, 2020

Strange, AppImage is still broken. https://build.opensuse.org/package/live_build_log/home:pbek:QOwnNotes/desktop/AppImage/x86_64

How can they not have QtConcurrent?

pbek added a commit that referenced this pull request Jan 9, 2020
@Waqar144
Copy link
Contributor Author

Did 9a090f0 work?

@pbek
Copy link
Owner

pbek commented Jan 10, 2020

Didn't make a new release yet with it. Don't bother, I'll take care of it. 😁

@pbek
Copy link
Owner

pbek commented Jan 10, 2020

Works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants